feat(storage): add support for bucket metadata call in async client#16262
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements the asynchronous GetBucket API across the Google Cloud Storage C++ SDK, including client interfaces, connection implementations, decorators, stubs, mocks, and tests. A review of the changes identified an issue in the integration tests where BucketName is constructed with an already-prefixed string, which would result in a double-prefixed bucket name.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16262 +/- ##
==========================================
- Coverage 92.27% 92.27% -0.01%
==========================================
Files 2214 2214
Lines 206537 206710 +173
==========================================
+ Hits 190589 190745 +156
- Misses 15948 15965 +17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bajajneha27
force-pushed
the
async-bucket-metadata
branch
from
July 16, 2026 03:50
d6a54d9 to
aff7403
Compare
bajajneha27
marked this pull request as ready for review
July 16, 2026 07:04
kalragauri
reviewed
Jul 17, 2026
bajajneha27
force-pushed
the
async-bucket-metadata
branch
from
July 17, 2026 07:22
0f51cbd to
23ec33e
Compare
kalragauri
approved these changes
Jul 17, 2026
scotthart
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.