Skip to content

doc: update library generation howto to use module path#16034

Merged
scotthart merged 1 commit intogoogleapis:mainfrom
scotthart:doc_howto_add_library
Mar 6, 2026
Merged

doc: update library generation howto to use module path#16034
scotthart merged 1 commit intogoogleapis:mainfrom
scotthart:doc_howto_add_library

Conversation

@scotthart
Copy link
Member

This PR updates the find target path to look in the module directory for googleapis.

@scotthart scotthart requested a review from a team as a code owner March 6, 2026 15:52
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the documentation for generating libraries, specifically correcting a path in a find command example. This ensures that contributors follow the correct procedure when identifying .proto files within the googleapis module directory.

Highlights

  • Documentation Update: The howto-guide-adding-generated-libraries.md file has been updated to correct the find command's path for locating .proto files, changing googleapis~ to googleapis+.
Changelog
  • doc/contributor/howto-guide-adding-generated-libraries.md
    • Updated the find command path from googleapis~ to googleapis+.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates a command in the contributor's guide for adding generated libraries. The change replaces the WORKSPACE-style path (googleapis~) with a module-style path (googleapis+) for locating googleapis in the bazel output base. This aligns the find command with other generator-related commands in the document that also use the module path. The change appears correct and consistent with the likely move towards using bzlmod for parts of the generation process. I have no further comments.

Note: Security Review has been skipped due to the limited scope of the PR.

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.64%. Comparing base (eea3715) to head (ba1bad0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16034      +/-   ##
==========================================
- Coverage   92.64%   92.64%   -0.01%     
==========================================
  Files        2335     2335              
  Lines      214792   214792              
==========================================
- Hits       198986   198985       -1     
- Misses      15806    15807       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart enabled auto-merge (squash) March 6, 2026 19:20
@scotthart scotthart merged commit 6b6c478 into googleapis:main Mar 6, 2026
57 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants