doc: update library generation howto to use module path#16034
doc: update library generation howto to use module path#16034scotthart merged 1 commit intogoogleapis:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the documentation for generating libraries, specifically correcting a path in a Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates a command in the contributor's guide for adding generated libraries. The change replaces the WORKSPACE-style path (googleapis~) with a module-style path (googleapis+) for locating googleapis in the bazel output base. This aligns the find command with other generator-related commands in the document that also use the module path. The change appears correct and consistent with the likely move towards using bzlmod for parts of the generation process. I have no further comments.
Note: Security Review has been skipped due to the limited scope of the PR.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16034 +/- ##
==========================================
- Coverage 92.64% 92.64% -0.01%
==========================================
Files 2335 2335
Lines 214792 214792
==========================================
- Hits 198986 198985 -1
- Misses 15806 15807 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR updates the
findtarget path to look in the module directory for googleapis.