Skip to content

chore(cpp): Update update cache sample and add ttl option #16032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bajajneha27 merged 4 commits into from
Mar 9, 2026
Merged

chore(cpp): Update update cache sample and add ttl option #16032

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5e090d
chore(cpp): Update update cache sample and add ttl option
bajajneha27 Mar 6, 2026
0d36482
fix ci failures
bajajneha27 Mar 6, 2026
d794091
fix ci failures
bajajneha27 Mar 6, 2026
11d9ab9
fix ci failures
bajajneha27 Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google/cloud/storagecontrol/v2/samples/storage_control_anywhere_cache_samples.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,9 @@ void UpdateAnywhereCache(
std::string const& admission_policy) {
google::storage::control::v2::AnywhereCache cache;
google::protobuf::FieldMask field_mask;
field_mask.add_paths("admission_policy");
field_mask.add_paths("ttl");
cache.set_name(cache_name);
cache.set_admission_policy(admission_policy);
cache->mutable_ttl()->set_seconds(86400);
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The cache object is a value type, not a pointer. You should use the . operator to access its members instead of ->. Using the arrow operator here will cause a compilation error.

Additionally, with this change, the admission_policy parameter is no longer used. Consider removing it from the function signature to avoid compiler warnings and improve code clarity.

    cache.mutable_ttl()->set_seconds(86400);

// Start an update operation and block until it completes. Real applications
// may want to setup a callback, wait on a coroutine, or poll until it
// completes.
Expand Down