Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RUN apt-get update && \

# #### Install CMake v3.22

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment indicates that CMake v3.22 is being installed, but the version has been updated to v3.31.11. Please update the comment to reflect the new version for consistency.

# #### Install CMake v3.31

WORKDIR /var/tmp/build/cmake
RUN curl -fsSL https://github.com/Kitware/cmake/archive/v3.22.3.tar.gz | \
RUN curl -fsSL https://github.com/Kitware/cmake/archive/v3.31.11.tar.gz | \
tar -xzf - --strip-components=1 && \
./bootstrap && make -j ${NCPU:-4} && make install

Expand Down
2 changes: 1 addition & 1 deletion doc/packaging.md
Original file line number Diff line number Diff line change
Expand Up @@ -905,7 +905,7 @@ sudo apt-get --no-install-recommends install -y apt-transport-https apt-utils \
#### Install CMake v3.22

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment indicates that CMake v3.22 is being installed, but the version has been updated to v3.31.11. Please update the comment to reflect the new version for consistency.

Suggested change
#### Install CMake v3.22
#### Install CMake v3.31


mkdir -p $HOME/Downloads/cmake && cd $HOME/Downloads/cmake curl -fsSL
https://github.com/Kitware/cmake/archive/v3.22.3.tar.gz | \
https://github.com/Kitware/cmake/archive/v3.31.11.tar.gz | \
tar -xzf - --strip-components=1 && \
./bootstrap && make -j ${NCPU:-4} && sudo make install

Expand Down