Skip to content

Conversation

@scotthart
Copy link
Member

No description provided.

@scotthart scotthart requested a review from a team as a code owner January 23, 2026 00:49
@gemini-code-assist
Copy link

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on maintaining the project's external dependencies by updating several key libraries to their latest versions within the MODULE.bazel file. Additionally, it streamlines the dependency list by removing components that are no longer explicitly required, ensuring the build system relies on current and compatible versions of its external tools and libraries.

Highlights

  • Dependency Updates: Updated boringssl from version 0.20241024.0 to 0.20251124.0.
  • Dependency Updates: Updated nlohmann_json from version 3.11.3 to 3.12.0.bcr.1.
  • Dependency Updates: Updated opentelemetry-cpp from version 1.22.0 to 1.24.0.
  • Dependency Updates: Updated googletest from version 1.17.0 to 1.17.0.bcr.2.
  • Dependency Removals: Removed the crc32c dependency.
  • Dependency Removals: Removed zlib and c-ares dependencies, which were previously noted as being used by curl.BUILD.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several Bazel dependencies in MODULE.bazel and removes some dependencies that are now likely transitive. While updating dependencies is good practice, and removing zlib and c-ares seems correct as they are likely transitive dependencies of curl, the removal of the crc32c dependency is concerning. crc32c is a direct and critical dependency for this project, and its removal could break bzlmod-based builds unless it is now provided as a transitive dependency from another module, which is not apparent. I have left a critical comment regarding this.

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.82%. Comparing base (4447f67) to head (f96d9d7).
⚠️ Report is 2 commits behind head on prepare-for-v3.0.0.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           prepare-for-v3.0.0   #15905      +/-   ##
======================================================
- Coverage               92.82%   92.82%   -0.01%     
======================================================
  Files                    2354     2354              
  Lines                  216302   216302              
======================================================
- Hits                   200780   200772       -8     
- Misses                  15522    15530       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart merged commit c083ccf into googleapis:prepare-for-v3.0.0 Jan 23, 2026
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant