-
Notifications
You must be signed in to change notification settings - Fork 438
impl(v3): remove deprecated Cloud Channel Reports service #15898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl(v3): remove deprecated Cloud Channel Reports service #15898
Conversation
Summary of ChangesHello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically removes all traces of the deprecated Cloud Channel Reports service from the codebase. By deleting its generation configuration, client library components, and associated documentation, the PR streamlines the project, eliminates unused code, and ensures that developers are not exposed to or reliant on a service that is no longer supported. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes the deprecated CloudChannelReportsService. The changes are comprehensive, deleting the service from the generator configuration, removing all associated source code files (including the client, connection, stubs, mocks, and samples), and updating the documentation to eliminate all references. The deletions are clean and align with the goal of removing the deprecated service. I have no further comments.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## prepare-for-v3.0.0 #15898 +/- ##
===================================================
Coverage 92.81% 92.82%
===================================================
Files 2354 2354
Lines 216338 216338
===================================================
+ Hits 200799 200817 +18
+ Misses 15539 15521 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ef567f3
into
googleapis:prepare-for-v3.0.0
No description provided.