Skip to content

Conversation

@scotthart
Copy link
Member

@scotthart scotthart commented Jan 21, 2026

This PR removes the absl_quiet_str_*.h wrapper headers and uses the absl/strings/str_*.h headers directly. It makes the necessary updates to the generator, generated code, and handwritten code.

@gemini-code-assist
Copy link

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's dependency on Abseil string utilities by eliminating an intermediate layer of custom wrapper headers. By directly incorporating the standard Abseil string headers, the change simplifies the build process and reduces maintenance overhead, affecting both the code generation logic and the generated client libraries.

Highlights

  • Abseil Header Simplification: The custom absl_quiet_str_*.h wrapper headers have been removed, and the codebase now directly uses the standard absl/strings/str_*.h headers for string manipulation functions like StrCat, StrJoin, and StrReplace.
  • Build System Update: The ci/cloudbuild/builds/checkers.sh script has been updated to remove a specific sed_edit transformation that was previously used to fix Abseil header issues on MSVC+x86, indicating that the custom wrappers are no longer needed.
  • Code Generation Alignment: The code generator and its generated output across numerous service clients and internal utilities have been updated to reflect the direct usage of standard Abseil string headers, ensuring consistency throughout the project.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the absl_quiet_str_*.h wrapper headers and directly uses the Abseil string headers. This is a great cleanup, removing a workaround that is no longer necessary. The changes are applied consistently across the codebase, including updates to the generator, generated code, and handwritten code. The removal of the fixup script in ci/cloudbuild/builds/checkers.sh is also correct. The changes are mostly mechanical and look good.

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.82%. Comparing base (c083ccf) to head (91095d9).

Files with missing lines Patch % Lines
...ator/internal/metadata_decorator_rest_generator.cc 0.00% 2 Missing ⚠️
generator/internal/option_defaults_generator.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           prepare-for-v3.0.0   #15897      +/-   ##
======================================================
- Coverage               92.82%   92.82%   -0.01%     
======================================================
  Files                    2354     2354              
  Lines                  216300   216298       -2     
======================================================
- Hits                   200779   200776       -3     
- Misses                  15521    15522       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart marked this pull request as ready for review January 22, 2026 16:25
@scotthart scotthart requested review from a team as code owners January 22, 2026 16:25
@scotthart scotthart enabled auto-merge (squash) January 22, 2026 17:11
@scotthart scotthart disabled auto-merge January 22, 2026 17:12
@scotthart scotthart force-pushed the v3_absl_quiet_headers branch from ace4a7d to d9c08ce Compare January 22, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants