-
Notifications
You must be signed in to change notification settings - Fork 438
impl(v3): delete absl quiet headers #15897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: prepare-for-v3.0.0
Are you sure you want to change the base?
impl(v3): delete absl quiet headers #15897
Conversation
Summary of ChangesHello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the project's dependency on Abseil string utilities by eliminating an intermediate layer of custom wrapper headers. By directly incorporating the standard Abseil string headers, the change simplifies the build process and reduces maintenance overhead, affecting both the code generation logic and the generated client libraries. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes the absl_quiet_str_*.h wrapper headers and directly uses the Abseil string headers. This is a great cleanup, removing a workaround that is no longer necessary. The changes are applied consistently across the codebase, including updates to the generator, generated code, and handwritten code. The removal of the fixup script in ci/cloudbuild/builds/checkers.sh is also correct. The changes are mostly mechanical and look good.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## prepare-for-v3.0.0 #15897 +/- ##
======================================================
- Coverage 92.82% 92.82% -0.01%
======================================================
Files 2354 2354
Lines 216300 216298 -2
======================================================
- Hits 200779 200776 -3
- Misses 15521 15522 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ace4a7d to
d9c08ce
Compare
This PR removes the
absl_quiet_str_*.hwrapper headers and uses theabsl/strings/str_*.hheaders directly. It makes the necessary updates to the generator, generated code, and handwritten code.