Skip to content

fix(gdch): support EC private keys #1896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegomarquezp merged 65 commits into from
Apr 8, 2026
+885 −103

Finalizing GDCH credentials support by addressing reviewer comments

a57def2
Select commit
Loading
Failed to load commit list.
Merged

fix(gdch): support EC private keys #1896

Finalizing GDCH credentials support by addressing reviewer comments
a57def2
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 26, 2026 in 54s

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 176 in oauth2_http/javatests/com/google/auth/oauth2/GdchCredentialsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=googleapis_google-auth-library-java&issues=AZ0d5slA1zUD9oIYwZ_i&open=AZ0d5slA1zUD9oIYwZ_i&pullRequest=1896

Check warning on line 154 in oauth2_http/javatests/com/google/auth/oauth2/GdchCredentialsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=googleapis_google-auth-library-java&issues=AZ0d5slA1zUD9oIYwZ_h&open=AZ0d5slA1zUD9oIYwZ_h&pullRequest=1896

Check warning on line 242 in oauth2_http/javatests/com/google/auth/oauth2/GdchCredentialsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=googleapis_google-auth-library-java&issues=AZ0d5slA1zUD9oIYwZ_l&open=AZ0d5slA1zUD9oIYwZ_l&pullRequest=1896

Check warning on line 319 in oauth2_http/javatests/com/google/auth/oauth2/GdchCredentialsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=googleapis_google-auth-library-java&issues=AZ0d5slA1zUD9oIYwZ_o&open=AZ0d5slA1zUD9oIYwZ_o&pullRequest=1896

Check warning on line 632 in oauth2_http/javatests/com/google/auth/oauth2/GdchCredentialsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this lambda with method reference 'credentials::refreshAccessToken'. 

See more on https://sonarcloud.io/project/issues?id=googleapis_google-auth-library-java&issues=AZ0d5slA1zUD9oIYwZ_p&open=AZ0d5slA1zUD9oIYwZ_p&pullRequest=1896

Check warning on line 198 in oauth2_http/javatests/com/google/auth/oauth2/GdchCredentialsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=googleapis_google-auth-library-java&issues=AZ0d5slA1zUD9oIYwZ_j&open=AZ0d5slA1zUD9oIYwZ_j&pullRequest=1896

Check warning on line 1062 in oauth2_http/javatests/com/google/auth/oauth2/GdchCredentialsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this lambda with method reference 'gdchWithAudience::refreshAccessToken'. 

See more on https://sonarcloud.io/project/issues?id=googleapis_google-auth-library-java&issues=AZ0d5slA1zUD9oIYwZ_t&open=AZ0d5slA1zUD9oIYwZ_t&pullRequest=1896

Check warning on line 1039 in oauth2_http/javatests/com/google/auth/oauth2/GdchCredentialsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this lambda with method reference 'gdchWithAudience::refreshAccessToken'. 

See more on https://sonarcloud.io/project/issues?id=googleapis_google-auth-library-java&issues=AZ0d5slA1zUD9oIYwZ_s&open=AZ0d5slA1zUD9oIYwZ_s&pullRequest=1896

Check warning on line 971 in oauth2_http/javatests/com/google/auth/oauth2/GdchCredentialsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this lambda with method reference 'gdchWithAudience::refreshAccessToken'. 

See more on https://sonarcloud.io/project/issues?id=googleapis_google-auth-library-java&issues=AZ0d5slA1zUD9oIYwZ_q&open=AZ0d5slA1zUD9oIYwZ_q&pullRequest=1896

Check warning on line 220 in oauth2_http/javatests/com/google/auth/oauth2/GdchCredentialsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=googleapis_google-auth-library-java&issues=AZ0d5slA1zUD9oIYwZ_k&open=AZ0d5slA1zUD9oIYwZ_k&pullRequest=1896

Check warning on line 301 in oauth2_http/javatests/com/google/auth/oauth2/GdchCredentialsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=googleapis_google-auth-library-java&issues=AZ0d5slA1zUD9oIYwZ_n&open=AZ0d5slA1zUD9oIYwZ_n&pullRequest=1896

Check warning on line 1016 in oauth2_http/javatests/com/google/auth/oauth2/GdchCredentialsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this lambda with method reference 'gdchWithAudience::refreshAccessToken'. 

See more on https://sonarcloud.io/project/issues?id=googleapis_google-auth-library-java&issues=AZ0d5slA1zUD9oIYwZ_r&open=AZ0d5slA1zUD9oIYwZ_r&pullRequest=1896

Check warning on line 279 in oauth2_http/javatests/com/google/auth/oauth2/GdchCredentialsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=googleapis_google-auth-library-java&issues=AZ0d5slA1zUD9oIYwZ_m&open=AZ0d5slA1zUD9oIYwZ_m&pullRequest=1896
View more details on SonarQubeCloud