fix: rename variable in generated test methods to avoid field name collision#1286
Open
aandreassa wants to merge 1 commit into
Open
fix: rename variable in generated test methods to avoid field name collision#1286aandreassa wants to merge 1 commit into
aandreassa wants to merge 1 commit into
Conversation
…llision Renames the local `client` variable (used when instantiating the service client under test) to `client_stub` across all gRPC and REST test templates. This prevents collisions with existing names. This fixes a generation error in google-cloud-run-v2 where the gem defines a field named `client` in `SubmitBuildRequest`. https://github.com/googleapis/googleapis/blob/a0cedfb6af9305b49db07dccaa7d0c8985e07e70/google/cloud/run/v2/build.proto#L143
aandreassa
changed the title
quartzmo
reviewed
May 14, 2026
Member
quartzmo
left a comment
quartzmo
left a comment
There was a problem hiding this comment.
Do you think it's too risky to name this variable c instead of client_stub?
It would save 10 characters!
Member
|
The Go clients use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the local
clientvariable (used when instantiating the service client under test) toclient_stubacross all gRPC and REST test templates.This prevents variable shadowing and collisions with existing names.
This fixes a generation error in
google-cloud-run-v2where the gem introduces a field namedclientinSubmitBuildRequest.Failed generation PR: googleapis/google-cloud-ruby#32252