feat: add retry jitter configuration#1256
Open
viacheslav-rostovtsev wants to merge 5 commits intogoogleapis:mainfrom
Open
feat: add retry jitter configuration#1256viacheslav-rostovtsev wants to merge 5 commits intogoogleapis:mainfrom
viacheslav-rostovtsev wants to merge 5 commits intogoogleapis:mainfrom
Conversation
Updates the client configuration templates to document the `:jitter` parameter in the `retry_policy` configuration. This aligns the generated documentation with the new jitter capability in `gapic-common`.
Adds tests to the showcase `wait` test suite to verify that the generated client passes the `jitter` configuration to `gapic-common` and that the sleep delay correctly respects the jitter bounds.
Regenerates the golden output files across all generators to reflect the documentation changes to the `retry_policy` configuration blocks.
Update the required gapic-common version in GemPresenter to ~> 1.3 to utilize the new retry jitter functionality.
Regenerated output to use gapic-common ~> 1.3
aandreassa
approved these changes
Mar 6, 2026
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
:jitterfield in theretry_policyconfiguration block. It is documented as aNumericwith a default of1.0.test_wait_retry_default_jitterandtest_wait_retry_configured_jitter) to verify the jitter logic is functioning correctly when utilizingwait.gapic-commondependency version to~> 1.3ingapic-generator/lib/gapic/presenters/gem_presenter.rbto utilize the new jitter features.retry_policydocumentation and the newgapic-commonversion dependency.