Fix generated pager tests for ListValue response fields #2532
+31
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching from
struct_pb2.ListValuetocollections.abc.Sequence(andStructtoMapping) to fix test failures identified in #2534 and make the generated tests more resilient.Why the test is failing
When we compare gRPC and HTTP responses:
struct_pb2.ListValue).requestsoraiohttp) usually returns native Python types (e.g., a standardlistordict) after the JSON body is decoded.Because a standard Python
listis not an instance ofstruct_pb2.ListValue, your checkisinstance(i, struct_pb2.ListValue)returnsFalsefor the HTTP response, even if the data inside is identical.The "Primitive" Types (ABCs)
The Protocol Buffer implementation for Python registers
StructandListValuewith Python’s Abstract Base Classes (ABCs). This means they are designed to "masquerade" as native collections.Structcollections.abc.Mappingcollections.abc.MutableMappingListValuecollections.abc.Sequencecollections.abc.MutableSequenceValueUpdated Check
This aligns the tests with
proto-plusbehavior regarding Well-Known Types.PR created automatically by Jules for task 9413892356993396464 started by @chalmerlowe