impl(bq_driver): Implementing ServiceAccountImpersonationEmail#1604
Draft
Khushikathuria008 wants to merge 1 commit into
Draft
impl(bq_driver): Implementing ServiceAccountImpersonationEmail#1604Khushikathuria008 wants to merge 1 commit into
Khushikathuria008 wants to merge 1 commit into
Conversation
Khushikathuria008
force-pushed
the
impersonation_email
branch
from
July 23, 2026 04:45
d53a851 to
3b99510
Compare
Khushikathuria008
temporarily deployed
to
internal
July 23, 2026 04:46 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
| TEST(StatementTest, VerifyServiceAccountImpersonationEmailSuccess) { | ||
| auto conn = std::make_shared<ODBCHandles>(); | ||
|
|
||
| std::string conn_str = kDefaultConnectionString + |
Collaborator
There was a problem hiding this comment.
have we verified on main as well that this test case will fail? looks like a generic change that might pass on main branch as well
Collaborator
Author
There was a problem hiding this comment.
Yes.
On main, even if we specify kirl-test@bigquery-devtools-drivers.iam.gserviceaccount.com as the ServiceAccountImpersonationEmail, the test still passes because main doesn't actually use or validate this parameter. After the recent changes, the driver starts honoring the ServiceAccountImpersonationEmail, so using this invalid email causes the test to fail as expected.
| EXPECT_EQ(Disconnect(conn), SQL_SUCCESS); | ||
| } | ||
|
|
||
| TEST(StatementTest, VerifyServiceAccountImpersonationEmailFailure) { |
Collaborator
There was a problem hiding this comment.
please combine both the test cases
Khushikathuria008
force-pushed
the
impersonation_email
branch
from
July 23, 2026 09:59
3b99510 to
a43f5ee
Compare
Khushikathuria008
force-pushed
the
impersonation_email
branch
from
July 23, 2026 10:18
3d8c98c to
142bf49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gha and macos check here.