fix: convert non-boolean additionalProperties to boolean in tool schemas#129
Open
lenanghai wants to merge 1 commit intogoogleanalytics:mainfrom
Open
fix: convert non-boolean additionalProperties to boolean in tool schemas#129lenanghai wants to merge 1 commit intogoogleanalytics:mainfrom
lenanghai wants to merge 1 commit intogoogleanalytics:mainfrom
Conversation
Some MCP clients (Claude Desktop, OpenAI Codex) expect
additionalProperties to be a boolean, not a JSON Schema object.
The ADK generates `additionalProperties: {"type": "string"}` for
Dict[str, Any] type hints, which causes these clients to fail
silently or reject the tool schema entirely.
This adds a recursive fix in the schema post-processing step that
converts any non-boolean additionalProperties to `true`.
Fixes googleanalytics#40
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
emwhipple30-svg
approved these changes
Mar 30, 2026
Member
|
@lenanghai Thanks for your submission. Can you sign the CLA here: https://cla.developers.google.com/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
additionalPropertiesin generated tool schemas that break MCP clients like Claude Desktop and OpenAI CodexadditionalProperties: {"type": "string"}forDict[str, Any]type hints, but some clients expect a boolean value_fix_additional_properties()function in the existing schema post-processing step incoordinator.pyRoot Cause
Parameters typed as
Dict[str, Any](e.g.,date_ranges,dimension_filter,metric_filter,order_bysinrun_report) produce JSON Schema withadditionalProperties: {"type": "string"}instead ofadditionalProperties: true. This causes:Failed to convert MCP tool: invalid type: map, expected a booleanTest plan
run_reporttool schema hasadditionalProperties: true(boolean) instead of{"type": "string"}run_reportrun_reportFixes #40
🤖 Generated with Claude Code