Open
Conversation
cosmicexplorer
approved these changes
Jan 15, 2026
cosmicexplorer
left a comment
cosmicexplorer
left a comment
There was a problem hiding this comment.
Does RE2 have any general expectations around documentation or test cases for an API change like this?
To be clear, your added test cases seem very thoughtful and appropriate. I am just curious if there is any sort of checklist that an outside contributor can complete that would make it easier for reviewers to accept it? [That question was directed at maintainers, not the PR author.]
Not trying to be annoying here—I love this project! Just in case it hadn't been considered!
Author
|
@rsc would you mind taking a peek at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimistically putting this up even though there isn't a whole lot of chatter on the mailing list post.