fix(vulnfeeds): output standard OSV YAML instead of wrapped format#5393
Merged
Conversation
yaml.v2 treats the anonymous *osvschema.Vulnerability field in the vulns.Vulnerability wrapper struct as a named 'Vulnerability' key. This caused new advisories to be written with a top-level 'vulnerability:' field after a recent bugfix initialized the pointer. This commit updates ToYAML, FromYAML, and FromJSON to encode and decode the inner osvschema.Vulnerability struct directly, restoring the standard OSV output format while maintaining the fix for nil pointer panics.
This was referenced May 18, 2026
jess-lowe
approved these changes
May 18, 2026
Contributor
jess-lowe
left a comment
There was a problem hiding this comment.
LGTM
Note to self: I'm pretty sure only the PyPi converter uses FromYAML, and FromJSON doesn't seem to be used elsewhere at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced in #5331, fixes #5390.
yaml.v2 treats the anonymous
*osvschema.Vulnerabilityfield in thevulns.Vulnerabilitywrapper struct as a namedVulnerabilitykey. This caused new advisories to be written with a top-levelvulnerability:field after a recent bugfix initialized the pointer.This commit updates
ToYAML,FromYAML, andFromJSONto encode and decode the innerosvschema.Vulnerabilitystruct directly, restoring the standard OSV output format while maintaining the fix for nil pointer panics.