feat: create allowlist of accepted ecosystems per datasource#5332
Merged
Hidden character warning
The head ref may contain hidden characters: "\ud83d\udee1\ufe0f\ud83c\udfdc\ufe0f\ud83c\udfde\ufe0f"
Conversation
jess-lowe
reviewed
May 12, 2026
| type: 2 | ||
| rest_api_url: 'https://cna.erlef.org/osv/all.json' | ||
| db_prefix: ['EEF-'] | ||
| accepted_ecosystems: ['Hex'] |
Contributor
There was a problem hiding this comment.
do we need a note that they also do Git or are we happy to exclude that?
Member
Author
There was a problem hiding this comment.
Git is kinda separate from ecosystems, and this filter doesn't really deal with it anyway.
I think ignore_git is probably meant to capture this (but why is it missing from eef?)
jess-lowe
reviewed
May 12, 2026
| extension='.json', | ||
| key_path='vulnerability', | ||
| ignore_git=False, | ||
| accepted_ecosystems=['Go', 'PyPI'], |
Contributor
There was a problem hiding this comment.
Why is this Go and PyPi?
Member
Author
There was a problem hiding this comment.
Just wanted to pick two random ecosystems to make sure the repeated field gets parsed properly
another-rex
previously approved these changes
May 14, 2026
jess-lowe
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5285
(merge after #5330)
Adding a new
accepted_ecosystemslist toSourceRepositoryto prevent data sources from publishing vulnerabilities to OSV.dev that are outside of their scopes.Did my best to go through and add all the ecosystems to the source yaml files - I don't think I've missed any.