feat: Add related computation to cron
#4704
Open
+358
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
another-rex
reviewed
Jan 29, 2026
go/cmd/relations/related.go
Outdated
Comment on lines
20
to
21
| // We want to prevent withdrawn vulns from being added to related groups. | ||
| // But if a non-withdrawn vuln has a withdrawn vuln as a related id, we want to add it. |
Contributor
There was a problem hiding this comment.
This could be worded a bit differently
We want to prevent withdrawn vulns IDs from being added to related groups, if the withdrawn vuln itself references other non-withdrawn vulns.
Contributor
There was a problem hiding this comment.
Maybe give some examples here as well.
another-rex
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
relatedvulns be regularly recomputed, so whenAupdates to related toB,Bwill get updated to relate toA.A withdrawn vuln will have non-withdrawn vulns added to its related field, but it will not add it's ID to the related fields of its own related vulns.
(i.e. if
Ais withdrawn and hasrelated: ["C"],Cwill not getAadded to its related field. If non-withdrawnBhasrelated: ["A"],Awill end up withrelated: ["B", "C"])