refactor(vulnfeeds): make nvd conversion run in parallel #4662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…VE for better clarity on which CVE format is in use
another-rex
reviewed
Jan 27, 2026
| var err error | ||
| switch *outFormat { | ||
| case "OSV": | ||
| err = nvd.CVEToOSV(cve, repos, RepoTagsCache, *outDir, metrics) |
Contributor
There was a problem hiding this comment.
nit: RepoTagsCache and VPRepoCache should be passed in via arguments
| if err != nil { | ||
| return err | ||
| } | ||
| var RepoTagsCache = &git.RepoTagsCache{} |
Contributor
There was a problem hiding this comment.
I think these should be defined in the main function and passed through arguments.
| // The RepoTags() call above will have cached the Tag map already | ||
| tagsMap := repoTagsCache[repoURL].Tag | ||
| repoTagsCache[repoURL] = RepoTagsMap{Tag: tagsMap, NormalizedTag: normalizedTags} | ||
| tagsMap, _ := repoTagsCache.Get(repoURL) |
Contributor
There was a problem hiding this comment.
nit: this probably shouldn't be called tagsMap, since it matches tagsMap on line 241, which is a completely different type, making it a bit confusing.
| }, | ||
| } | ||
| cache := make(RepoTagsCache) | ||
| cache := &RepoTagsCache{} |
Contributor
There was a problem hiding this comment.
rename to repoTagsCache to keep it consistent.
|
|
||
| // Adds the repo to the cache for the Vendor/Product combination if not already present. | ||
| func MaybeUpdateVPRepoCache(cache VendorProductToRepoMap, vp *VendorProduct, repo string) { | ||
| func MaybeUpdateVPRepoCache(cache *VPRepoCache, vp *VendorProduct, repo string) { |
Contributor
There was a problem hiding this comment.
These all should be methods on VPRepoCache I think.
| Product string | ||
| } | ||
| type VendorProductToRepoMap map[VendorProduct][]string | ||
| type VPRepoCache struct { |
Contributor
There was a problem hiding this comment.
Add an init function as well, and use that instead of manually setting M, and make M private.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should dramatically improve conversion time.
Also changes NVD conversion to write out ConversionMetrics in the same way that the CVE5 conversion does.
Should be merged after #4650
Confirmed writing out PackageInfo still works too.