Refactor per-worker save/load GB and GB/s metrics. These are now framed as global statistics, logged from a leader process, in contrast to /jax/orbax/*/worker/* metrics. In particular, delegation to TypeHandlers for memory size is eliminated and we rely instead on more expedient logic to determine global array sizes. This approach also has the virtue of being Pathways / mcJAX independent.#3399
Open
copybara-service[bot] wants to merge 1 commit into
Open
Refactor per-worker save/load GB and GB/s metrics. These are now framed as global statistics, logged from a leader process, in contrast to /jax/orbax/*/worker/* metrics. In particular, delegation to TypeHandlers for memory size is eliminated and we rely instead on more expedient logic to determine global array sizes. This approach also has the virtue of being Pathways / mcJAX independent.#3399copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
1eb840e to
611a87f
Compare
…ed as global statistics, logged from a leader process, in contrast to /jax/orbax/*/worker/* metrics. In particular, delegation to TypeHandlers for memory size is eliminated and we rely instead on more expedient logic to determine global array sizes. This approach also has the virtue of being Pathways / mcJAX independent. PiperOrigin-RevId: 936112283
611a87f to
32d2494
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor per-worker save/load GB and GB/s metrics. These are now framed as global statistics, logged from a leader process, in contrast to /jax/orbax//worker/ metrics. In particular, delegation to TypeHandlers for memory size is eliminated and we rely instead on more expedient logic to determine global array sizes. This approach also has the virtue of being Pathways / mcJAX independent.