Fix poor test isolation in plugs_test.py (issue #753)#1294
Open
harrish243 wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
plugs_test.py had several class-level state leaks that made tests order-dependent and relied (in older versions) on a real socket being opened by FrontendAwareBasePlug via xmlrpcutil.SimpleThreadedXmlRpcServer. Changes: - Add module-level docstring explaining the hermetic design contract. - Reset AdderPlug.LAST_INSTANCE in setUp() so each test starts with a clean slate (previously only INSTANCE_COUNT was reset, causing the LAST_INSTANCE reference from one test to bleed into the next). - Reset TearDownRaisesPlug1.TORN_DOWN and TearDownRaisesPlug2.TORN_DOWN in setUp() so test_tear_down_raises cannot influence other tests via shared class-level boolean state. - Add class-level and method-level docstrings that document why state is reset and confirm that no network socket is opened. - Add a docstring to test_plug_updates() making it explicit that the update-notification path uses only in-process threading.Event objects (via SubscribableStateMixin) and no socket is involved. All 9 existing tests continue to pass.
6907f56 to
22c1362
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #753
plugs_test.py had several class-level state leaks that made tests order-dependent and relied (in older versions) on a real socket being opened by FrontendAwareBasePlug via xmlrpcutil.SimpleThreadedXmlRpcServer.
Changes:
All 9 existing tests continue to pass.