Add "traffic" label to nomulus pod templates#3046
Merged
Merged
Conversation
ptkach
approved these changes
May 14, 2026
Collaborator
ptkach
left a comment
There was a problem hiding this comment.
@ptkach reviewed 4 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on jicelhay).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want existing Services to load balance traffic across stable and canary/partial Deployments.
Right now, the Service selector routes based on the
servicelabel. However, we can't add that label to new canary/partial Deployments because it would conflict with the stable Deployment'sspec.selector.matchLabelsand it will cause conflicts over pod management.The end goal is to add the new label to pods and then to switch the Service's selector to route based on this new label. We're doing this in 2 steps to ensure that this is doesn't disrupt traffic when deployed (services trying to route traffic but pods that don't have the label yet) and adding a release in between to be backwards compatible (if we rollback deployments, they will still have the new tag when the service change is deployed).
This change is