Skip to content

Add "traffic" label to nomulus pod templates#3046

Merged
jicelhay merged 1 commit into
google:masterfrom
jicelhay:partialmanifests
May 14, 2026
Merged

Add "traffic" label to nomulus pod templates#3046
jicelhay merged 1 commit into
google:masterfrom
jicelhay:partialmanifests

Conversation

@jicelhay
Copy link
Copy Markdown
Collaborator

@jicelhay jicelhay commented May 14, 2026

We want existing Services to load balance traffic across stable and canary/partial Deployments.

Right now, the Service selector routes based on the service label. However, we can't add that label to new canary/partial Deployments because it would conflict with the stable Deployment's spec.selector.matchLabels and it will cause conflicts over pod management.

The end goal is to add the new label to pods and then to switch the Service's selector to route based on this new label. We're doing this in 2 steps to ensure that this is doesn't disrupt traffic when deployed (services trying to route traffic but pods that don't have the label yet) and adding a release in between to be backwards compatible (if we rollback deployments, they will still have the new tag when the service change is deployed).


This change is Reviewable

@jicelhay jicelhay requested a review from ptkach May 14, 2026 15:13
Copy link
Copy Markdown
Collaborator

@ptkach ptkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptkach reviewed 4 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on jicelhay).

@jicelhay jicelhay added this pull request to the merge queue May 14, 2026
Merged via the queue into google:master with commit 0998d54 May 14, 2026
10 checks passed
@jicelhay jicelhay deleted the partialmanifests branch May 14, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants