Simplify SQL credential store #2955
Open
+20
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current SQL credential store was designed to support automatic password rotation without any disruption to the applications. For that goal, the credentials are stored with one level of indirection, and the secret name of the actual credential data may change automatically. The automatic password rotation feature has been dropped. In the meantime, the need arises that we use sidecar SQL proxy to get around the Enterprise Plus edition's post-maintenance reconnection failures by the socket factory library. This is hampered by the indirection in storage. This PR removes the indirection. This change is transparent to the rest of the code base. We will manually populate the secret manager with the new secrets in all environments after submissiion of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current SQL credential store was designed to support automatic password rotation without any disruption to the applications. For that goal, the credentials are stored with one level of indirection, and the secret name of the actual credential data may change automatically.
The automatic password rotation feature has been dropped. In the meantime, the need arises that we use sidecar SQL proxy to get around the Enterprise Plus edition's post-maintenance reconnection failures by the socket factory library. This is hampered by the indirection in storage.
This PR removes the indirection. This change is transparent to the rest of the code base. We will manually populate the secret manager with the new secrets in all environments after submissiion of this PR.
This change is