Skip to content

Improve error messages when typeToCode throws an exception#1450

Merged
kevmoo merged 5 commits intogoogle:masterfrom
fromkeith:typeToCode-errorMessage
Mar 18, 2026
Merged

Improve error messages when typeToCode throws an exception#1450
kevmoo merged 5 commits intogoogle:masterfrom
fromkeith:typeToCode-errorMessage

Conversation

@fromkeith
Copy link
Copy Markdown
Contributor

typeToCode can throw an expection, which reduces the error message to:

UnimplementedError: (InvalidTypeImpl) InvalidType
package:json_serializable/src/utils.dart 221:3              typeToCode
package:json_serializable/src/helper_core.dart 79:46        createInvalidGenerationError
...

This change improves the error message to something like this:

Could not generate `fromJson` code for `photos` because of type is unimplemented/unsupported/undefined.
package:picthrive_kiosk/ptclient/generated/consolidated_public.swagger.dart:2633:21
     ╷
2633 │   final List<Items> photos;
     │                     ^^^^^^
     ╵

`typeToCode` can throw an expection, which reduces the error message to:

```
UnimplementedError: (InvalidTypeImpl) InvalidType
package:json_serializable/src/utils.dart 221:3              typeToCode
package:json_serializable/src/helper_core.dart 79:46        createInvalidGenerationError
...
```

This change improves the error message to something like this:

```
Could not generate `fromJson` code for `photos` because of type is unimplemented/unsupported/undefined.
package:picthrive_kiosk/ptclient/generated/consolidated_public.swagger.dart:2633:21
     ╷
2633 │   final List<Items> photos;
     │                     ^^^^^^
     ╵

```
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Oct 11, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Comment thread json_serializable/lib/src/helper_core.dart
@kevmoo kevmoo merged commit 6b711e3 into google:master Mar 18, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants