Merge dynamic constant propagation into the constprop pass - #146
Open
amarkdotdev wants to merge 1 commit into
Open
Merge dynamic constant propagation into the constprop pass#146amarkdotdev wants to merge 1 commit into
amarkdotdev wants to merge 1 commit into
Conversation
Both transforms apply the same rewrite; the dynamic path only swaps in a richer analysis. One MLIR pass now covers both configs. Fixes google#19 Signed-off-by: Aaron <amark@g.jct.ac.il>
Collaborator
|
Thanks for the contribution! We currently only have a process to sync internal changes to github, but not the opposite direction. I'll need to manually create a matching internal change and merge your PR at just the right time :) This will take some time (maybe several days) to figure out, so please be patient in the meantime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordinary and dynamic constant propagation run the same rewrite; the dynamic path only loads
JsirDynamicConstantPropagationAnalysis(prelude matching) first. There is no reason for two MLIR pass classes.JsirConstantPropagationPassnow handles bothJsirTransformConfigkinds.PerformDynamicConstantPropagationlives next toPerformConstantPropagation, and the old dynamic pass.ccis gone. CLI names (constprop/dynconstprop) and proto fields are unchanged.Fixes #19