Skip to content

Do not treat Mongolian vowel separator as a whitespace #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zbynek wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not treat Mongolian vowel separator as a whitespace #2671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 2 additions & 16 deletions jre_emul/android/platform/libcore/luni/src/test/java/libcore/java/lang/CharacterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,14 +245,7 @@ public void test_isSpaceChar_against_icu4c() throws Exception {
Method m = Character.class.getDeclaredMethod("isSpaceChar" + "Impl", int.class);
m.setAccessible(true);
for (int i = 0; i <= 0xffff; ++i) {
// ICU and the RI disagree about character 0x180e. Remove this special case if this changes
// or Android decides to follow ICU exactly.
if (i == 0x180e) {
assertTrue(Character.isSpaceChar(i));
assertFalse((Boolean) m.invoke(null, i));
} else {
assertEquals("Failed for character " + i, m.invoke(null, i), Character.isSpaceChar(i));
}
assertEquals("Failed for character " + i, m.invoke(null, i), Character.isSpaceChar(i));
}
}

Expand All @@ -270,14 +263,7 @@ public void test_isWhitespace_against_icu4c() throws Exception {
Method m = Character.class.getDeclaredMethod("isWhitespace" + "Impl", int.class);
m.setAccessible(true);
for (int i = 0; i <= 0xffff; ++i) {
// ICU and the RI disagree about character 0x180e. Remove this special case if this changes
// or Android decides to follow ICU exactly.
if (i == 0x180e) {
assertTrue(Character.isWhitespace(i));
assertFalse((Boolean) m.invoke(null, i));
} else {
assertEquals("Failed for character " + i, m.invoke(null, i), Character.isWhitespace(i));
}
assertEquals("Failed for character " + i, m.invoke(null, i), Character.isWhitespace(i));
}
}

Expand Down
8 changes: 4 additions & 4 deletions jre_emul/android/platform/libcore/ojluni/src/main/java/java/lang/Character.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7296,8 +7296,8 @@ public static boolean isSpaceChar(int codePoint) {
if (codePoint < 0x1000) {
return false;
}
// OGHAM SPACE MARK or MONGOLIAN VOWEL SEPARATOR?
if (codePoint == 0x1680 || codePoint == 0x180e) {
// OGHAM SPACE MARK?
if (codePoint == 0x1680) {
return true;
}
if (codePoint < 0x2000) {
Expand Down Expand Up @@ -7393,8 +7393,8 @@ public static boolean isWhitespace(int codePoint) {
if (codePoint < 0x1000) {
return false;
}
// OGHAM SPACE MARK or MONGOLIAN VOWEL SEPARATOR?
if (codePoint == 0x1680 || codePoint == 0x180e) {
// OGHAM SPACE MARK?
if (codePoint == 0x1680) {
return true;
}
if (codePoint < 0x2000) {
Expand Down