Skip to content

[Dockerfile]: add omp-dev and yosys into docker image#2572

Merged
copybara-service[bot] merged 2 commits intogoogle:mainfrom
ai-mannamalai:main
Mar 12, 2026
Merged

[Dockerfile]: add omp-dev and yosys into docker image#2572
copybara-service[bot] merged 2 commits intogoogle:mainfrom
ai-mannamalai:main

Conversation

@ai-mannamalai
Copy link
Copy Markdown
Contributor

[Dockerfile]: add omp-dev and yosys into docker image

@j2kun
Copy link
Copy Markdown
Collaborator

j2kun commented Jan 23, 2026

I am surprised you need to apt-install yosys, since bazel manages the sources with an explicit URL.

For openmp, you may prefer to run the script that we use in CI to set up a specific clang+openmp: .github/install_clang_version.sh

You can run it as

./.github/install_clang_version.sh 19

Let me know if that works, and then the dockerfile can stay up to date with the repo by default.

@ai-mannamalai
Copy link
Copy Markdown
Contributor Author

Not sure; will try.

@ai-mannamalai
Copy link
Copy Markdown
Contributor Author

When I try your suggestion it gives some problems; getting a correct clang++ version is not my problem yet - can be handled just the same with Dockerfile commands already in there.

[mannamalai@core-emu-5 docker]$ ./run.sh 
[+] Building 0.8s (10/15)                                                                                                                                                          docker:default
 => [internal] load build definition from Dockerfile                                                                                                                                         0.0s
 => => transferring dockerfile: 2.46kB                                                                                                                                                       0.0s
 => [internal] load metadata for docker.io/library/ubuntu:24.04                                                                                                                              0.3s
 => [internal] load .dockerignore                                                                                                                                                            0.0s
 => => transferring context: 2B                                                                                                                                                              0.0s
 => [internal] load build context                                                                                                                                                            0.0s
 => => transferring context: 81B                                                                                                                                                             0.0s
 => [ 1/11] FROM docker.io/library/ubuntu:24.04@sha256:cd1dba651b3080c3686ecf4e3c4220f026b521fb76978881737d24f200828b2b                                                                      0.0s
 => CACHED [ 2/11] RUN apt-get update &&     apt-get install -y     apt-utils     build-essential     curl     git     zip     unzip     python3-dev     python3-pip     python3-venv     o  0.0s
 => CACHED [ 3/11] WORKDIR /tmp                                                                                                                                                              0.0s
 => CACHED [ 4/11] COPY ../.github/install_clang_version.sh /tmp/install_clang_version.sh                                                                                                    0.0s
 => [ 5/11] WORKDIR /tmp                                                                                                                                                                     0.0s
 => ERROR [ 6/11] RUN  /tmp/install_clang_version.sh 19                                                                                                                                      0.4s
------
 > [ 6/11] RUN  /tmp/install_clang_version.sh 19:
0.237 /tmp/install_clang_version.sh: line 16: sudo: command not found
0.243 --2026-01-28 20:35:51--  https://apt.llvm.org/llvm-snapshot.gpg.key
0.286 Resolving apt.llvm.org (apt.llvm.org)... 199.232.198.49, 199.232.194.49, 2a04:4e42:4c::561, ...
0.302 Connecting to apt.llvm.org (apt.llvm.org)|199.232.198.49|:443... connected.
0.310 HTTP request sent, awaiting response... 200 OK
0.312 Length: 3145 (3.1K) [application/octet-stream]
0.312 Saving to: 'STDOUT'
0.312 
0.312      0K                                                         0% 0.00 =0s
0.312 
0.312 
0.312 Cannot write to '-' (Success).
------
Dockerfile:59
--------------------
  57 |     
  58 |     WORKDIR /tmp
  59 | >>> RUN  /tmp/install_clang_version.sh ${CLANG_VERSION}
  60 |     
  61 |     RUN update-alternatives --install /usr/bin/python python /usr/bin/python3 1 && \
--------------------
ERROR: failed to solve: process "/bin/sh -c /tmp/install_clang_version.sh ${CLANG_VERSION}" did not complete successfully: exit code: 127
[mannamalai@core-emu-5 docker]$ 

@ai-mannamalai
Copy link
Copy Markdown
Contributor Author

I added a small change (code cleanup as well)

Comment thread docker/Dockerfile
Comment thread lib/Dialect/LWE/Conversions/LWEToLattigo/LWEToLattigo.cpp
@ai-mannamalai
Copy link
Copy Markdown
Contributor Author

done

@j2kun
Copy link
Copy Markdown
Collaborator

j2kun commented Feb 10, 2026

Please squash the commits. thanks!

@ai-mannamalai
Copy link
Copy Markdown
Contributor Author

@j2kun - please release the PR as you find time. I rebased to main.

@j2kun j2kun added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Mar 12, 2026
@copybara-service copybara-service Bot merged commit 43c2b0f into google:main Mar 12, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants