[Dockerfile]: add omp-dev and yosys into docker image#2572
Merged
copybara-service[bot] merged 2 commits intogoogle:mainfrom Mar 12, 2026
Merged
[Dockerfile]: add omp-dev and yosys into docker image#2572copybara-service[bot] merged 2 commits intogoogle:mainfrom
copybara-service[bot] merged 2 commits intogoogle:mainfrom
Conversation
Collaborator
|
I am surprised you need to apt-install yosys, since bazel manages the sources with an explicit URL. For openmp, you may prefer to run the script that we use in CI to set up a specific clang+openmp: You can run it as ./.github/install_clang_version.sh 19Let me know if that works, and then the dockerfile can stay up to date with the repo by default. |
Contributor
Author
|
Not sure; will try. |
Contributor
Author
|
When I try your suggestion it gives some problems; getting a correct clang++ version is not my problem yet - can be handled just the same with Dockerfile commands already in there. |
Contributor
Author
|
I added a small change (code cleanup as well) |
j2kun
approved these changes
Feb 3, 2026
Contributor
Author
|
done |
j2kun
approved these changes
Feb 10, 2026
Collaborator
|
Please squash the commits. thanks! |
Contributor
Author
|
@j2kun - please release the PR as you find time. I rebased to main. |
j2kun
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Dockerfile]: add omp-dev and yosys into docker image