Serialize PCI device hierarchy and top-level attribute files per NUMA node#13312
Open
atoniolo76 wants to merge 2 commits into
Open
Serialize PCI device hierarchy and top-level attribute files per NUMA node#13312atoniolo76 wants to merge 2 commits into
atoniolo76 wants to merge 2 commits into
Conversation
… ib_write_bw and reconstruct in container. Gate on RDMAProxy config flag.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks off #13297 and based on #13114. Adds serialization of the PCI device hierarchy in sysfs collected from
/sys/bus/pci/devices/, filtering for GPU, InfiniBand NICs, PCI bridge, and NVSwitch device classes only. Exposes NUMA topology filescpumap,cpulist, anddistancefrom/sys/devices/system/node/node{N}/for all nodes and includes the top-level aggregate filesonline,possible,has_cpu,has_memory, andhas_normal_memoryat/sys/devices/system/node/.Tested and confirmed full line rate bandwidth:

Files added:
pci_devices.goaddsPCIDeviceAttrstruct containing address, realpath, class, vendor, device, subsystem IDs, numa_node, local_cpus, and link speed/width information. Filters for GPU/NIC/Bridge/NVSwitch devices bypciClassRelevant(). Reads PCI device attribute files and walks through the/sys/bus/pci/devices/directory starting at leaf devices and ending at ancestor bridges. Other plumbing for serializing the data and re-building the chroot sysfs tree.numa.goaddsNUMANodeDatastruct for id, cpumap, cpulist, and distance information. AddsNUMADatastructure for theonline,possible,has_cpu,has_memory,has_normal_memoryaggregate files. Reads from/sys/devices/system/node/node{N}/per-node to buildNUMANodeData. Other plumbing for serializing the data and re-building the node directories with the attribute files plus the aggregate files at the/sys/devices/system/node/level.Files modified:
pkg/sentry/fsimpl/sys/sys.goaddsPCIDevicesDataandNUMADatafields to theInternalDatastruct. CallsnewPCIDevicesSysfsEntries()andnewNUMASysfsEntries().runsc/cmd/chroot.goaddspciDevicesUpdateChroot()andnumaUpdateChroot()functions, which are called before chroot while host sysfs is still accessible and passed as argsPCIDevicesDataandNUMADatainto boot.runsc/cmd/boot.goadds calls toDeserializePCIDevicesData()andDeserializeNUMAData()after pivot root.runsc/boot/loader.goaddspciDevicesDataandnumaDatafields to the loader struct.runsc/boot/vfs.gopassespciDevicesDataandnumaDatainto mount options to make available for the sysfs filesystem constructor.