Fix sentry panic during path resolution from unlinked directories in tmpfs.#13294
Open
copybara-service[bot] wants to merge 1 commit into
Open
Fix sentry panic during path resolution from unlinked directories in tmpfs.#13294copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…tmpfs. In tmpfs, child directories did not hold a reference to their parents. If a directory was unlinked but kept alive, for example, cwd, its parent could also be unlinked and have its refcount drop to 0 and destroyed. When the process in the child directory subsequently tried to `cd ..`, it resolved to the parent dir and called `IncRef` on it. Since the parent directory was already destroyed, this triggered the "non-positive count" panic. Assisted-by: jetski PiperOrigin-RevId: 921630834
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix sentry panic during path resolution from unlinked directories in tmpfs.
In tmpfs, child directories did not hold a reference to their parents. If a
directory was unlinked but kept alive, for example, cwd, its parent
could also be unlinked and have its refcount drop to 0 and destroyed.
When the process in the child directory subsequently tried
to
cd .., it resolved to the parent dir and calledIncRefon it. Sincethe parent directory was already destroyed, this triggered the
"non-positive count" panic.
Assisted-by: jetski