feat: Add CRI-O compatibility for containerd-shim-runsc-v1#13279
Open
xw19 wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Signed-off-by: Sourav Moitra <sourav.moitr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update addresses two critical issues preventing containerd-shim-runsc-v1 from functioning with CRI-O when runtime_type=vm is configured. First, it resolves a shim grouping failure by adding support for CRI-O’s sandbox annotation (io.kubernetes.cri-o.SandboxID), ensuring sub-containers correctly identify their parent sandbox instead of spawning independent, non-functional shims. Second, it fixes a stability issue where the shim would panic due to missing containerd event addresses; these fatal panics have been replaced with non-fatal warning logs. Finally, to ensure successful deployment, a new quick-start guide has been added to g3doc/user_guide/containerd/ detailing the required configuration to complement the companion fix in cri-o/cri-o#9974
Fixes: #10313