Make addSpan an instance method of TokenVisitor.#1367
Merged
copybara-service[bot] merged 1 commit intomasterfrom Apr 4, 2026
Merged
Make addSpan an instance method of TokenVisitor.#1367copybara-service[bot] merged 1 commit intomasterfrom
addSpan an instance method of TokenVisitor.#1367copybara-service[bot] merged 1 commit intomasterfrom
Conversation
copybara-service
bot
force-pushed
the
test_894319740
branch
from
140839c to
9ce1e82
Compare
Since the callers are all inside `TokenVisitor` too, they no longer need to pass the `positionToToken` field. PiperOrigin-RevId: 894607945
copybara-service
bot
force-pushed
the
test_894319740
branch
from
9ce1e82 to
ffd5425
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
addSpanan instance method ofTokenVisitor.Since the callers are all inside
TokenVisitortoo, they no longer need to pass thepositionToTokenfield.