refactor!: Pass CreateJITConfigRequest by value and rename Generate*JITConfig to Create*JITConfig

[JamBalaya56562]

BREAKING CHANGE: the JIT config methods are renamed from Generate*JITConfig to Create*JITConfig, and they now take CreateJITConfigRequest (renamed from GenerateJITConfigRequest) by value instead of by pointer.

Towards #3644.

Continues the value-parameter conversion from the merged #3654, #3794, #4320, #4329 and #4336.

Changes

• Pass the request by value: CreateOrgJITConfig / CreateRepoJITConfig (actions_runners.go) and (*EnterpriseService).CreateJITConfig (enterprise_actions_runners.go) now take CreateJITConfigRequest by value. All three methods share the same request type, so they are converted together (otherwise the paramcheck allow-list entry could not be removed). The type is removed from the paramcheck body-allowed-pointer-types allow-list in .golangci.yml.
• Rename Generate*JITConfig -> Create*JITConfig (methods) and GenerateJITConfigRequest -> CreateJITConfigRequest, to match the API docs operation name ("Create configuration for a just-in-time runner"). On EnterpriseService the method is just CreateJITConfig (the redundant Enterprise is dropped, consistent with the other EnterpriseService runner methods). The generate-jitconfig URL path is unchanged.
• Add missing Runner fields: runner_group_id, ephemeral, and version to the Runner response struct to match the self-hosted runner schema (these are returned by JITRunnerConfig and by the runner list/get endpoints). All optional, so non-breaking; accessors regenerated.

Breaking changes

• GenerateOrgJITConfig / GenerateRepoJITConfig renamed to CreateOrgJITConfig / CreateRepoJITConfig; GenerateEnterpriseJITConfig renamed to CreateJITConfig (on EnterpriseService).
• They now take CreateJITConfigRequest (renamed from GenerateJITConfigRequest) by value instead of *GenerateJITConfigRequest.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.50%. Comparing base (4498e09) to head (41caceb).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4337   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files         193      193           
  Lines       19451    19451           
=======================================
  Hits        18965    18965           
  Misses        269      269           
  Partials      217      217           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gmlewis]

Thank you, @JamBalaya56562!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @Not-Dhananjay-Mishra

[Not-Dhananjay-Mishra]

let's also update JITRunnerConfig to match the schema. There are some missing fields (runner_group_id, ephemeral, version)

{
  "type": "object",
  "required": [
    "runner",
    "encoded_jit_config"
  ],
  "properties": {
    "runner": {
      "title": "Self hosted runners",
      "description": "A self hosted runner",
      "type": "object",
      "properties": {
        "id": {
          "description": "The ID of the runner.",
          "type": "integer"
        },
        "runner_group_id": {
          "description": "The ID of the runner group.",
          "type": "integer"
        },
        "name": {
          "description": "The name of the runner.",
          "type": "string"
        },
        "os": {
          "description": "The Operating System of the runner.",
          "type": "string"
        },
        "status": {
          "description": "The status of the runner.",
          "type": "string"
        },
        "busy": {
          "type": "boolean"
        },
        "labels": {
          "type": "array",
          "items": {
            "title": "Self hosted runner label",
            "description": "A label for a self hosted runner",
            "type": "object",
            "properties": {
              "id": {
                "type": "integer",
                "description": "Unique identifier of the label."
              },
              "name": {
                "type": "string",
                "description": "Name of the label."
              },
              "type": {
                "type": "string",
                "description": "The type of label. Read-only labels are applied automatically when the runner is configured.",
                "enum": [
                  "read-only",
                  "custom"
                ]
              }
            },
            "required": [
              "name"
            ]
          }
        },
        "ephemeral": {
          "type": "boolean"
        },
        "version": {
          "description": "The version of the GitHub Actions Runner software. This is only set if the runner has connected to the service at least once.",
          "type": [
            "string",
            "null"
          ]
        }
      },
      "required": [
        "id",
        "name",
        "os",
        "status",
        "busy",
        "labels"
      ]
    },
    "encoded_jit_config": {
      "type": "string",
      "description": "The base64 encoded runner configuration."
    }
  }
}

[JamBalaya56562]

Thanks @Not-Dhananjay-Mishra — done. Added runner_group_id, ephemeral and version to the Runner struct (all optional, to match the schema) in a separate commit (03fcee1), with accessors regenerated. JITRunnerConfig itself already had runner + encoded_jit_config.

[Not-Dhananjay-Mishra]

LGTM