Refactor Windows service helpers for testability and improve RestartServiceWithVerify.#776
Open
copybara-service[bot] wants to merge 1 commit into
Open
Refactor Windows service helpers for testability and improve RestartServiceWithVerify.#776copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_903171985
branch
from
105ef8f to
f944cfa
Compare
…erviceWithVerify. Introduced mockable variables for Windows service management functions and time.Sleep in helpers_windows.go. Updated all service-related functions to use these new variables. Improved RestartServiceWithVerify to more accurately handle service state transitions by querying the actual service state immediately after restart and looping until the service is in the svc.Running state. Added TestRestartServiceWithVerify in helpers_windows_test.go to test various service restart scenarios, including pending states and timeouts. PiperOrigin-RevId: 903171985
copybara-service
Bot
force-pushed
the
test_903171985
branch
from
f944cfa to
cbdce64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Windows service helpers for testability and improve RestartServiceWithVerify.
Introduced mockable variables for Windows service management functions and time.Sleep in helpers_windows.go. Updated all service-related functions to use these new variables. Improved RestartServiceWithVerify to more accurately handle service state transitions by querying the actual service state immediately after restart and looping until the service is in the svc.Running state. Added TestRestartServiceWithVerify in helpers_windows_test.go to test various service restart scenarios, including pending states and timeouts.