Relax the checking of std::filesystem::create_directories for seed inputs dir.#2053
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Relax the checking of std::filesystem::create_directories for seed inputs dir.#2053copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
…puts dir. Sometimes the seed inputs dir may exist if previous cleanup failed, but there is nothing wrong with reusing the previous dir. The check on `error` later should be enough to ensure that the seed inputs dir exists. PiperOrigin-RevId: 910954133
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relax the checking of std::filesystem::create_directories for seed inputs dir.
Sometimes the seed inputs dir may exist if previous cleanup failed, but there is nothing wrong with reusing the previous dir.
The check on
errorlater should be enough to ensure that the seed inputs dir exists.