Prioritize custom printers over default aggregate printing.#1982
Closed
copybara-service[bot] wants to merge 0 commit intomainfrom
Closed
Prioritize custom printers over default aggregate printing.#1982copybara-service[bot] wants to merge 0 commit intomainfrom
copybara-service[bot] wants to merge 0 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
cl/868817106
branch
from
cbffde6 to
855770b
Compare
copybara-service
bot
force-pushed
the
cl/868817106
branch
from
855770b to
d8e979e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prioritize custom printers over default aggregate printing.
This change makes
AbslStringifyandFuzzTestPrintSourceCodetake precedence over the default field-level printing for aggregate types. If a custom printer is defined for a type, it will be used for both human-readable and source-code modes, with fallback betweenAbslStringifyandFuzzTestPrintSourceCode. The documentation is updated to reflect this behavior.This reduces the amount of boilerplate that the user has to write to override the default field-level printing: with the change, it suffices to define
AbslStringify. This is important for aggregate types that have a nested C-style array, for which the aggregate detection yields a compile-time error.