build(java): add stable JPMS module name#9118
Open
KirtiRamchandani wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
flatbuffers-javacurrently lands on the module path as a filename-derived automatic module, so downstreammodule-info.javafiles see the unstable nameflatbuffers.javaand modular builds can warn about publishing with filename-based automodules.Root cause
The Java artifact does not declare any JPMS module name metadata, while the Maven build still targets Java 8 (
--release 8on newer JDKs). Adding a top-levelmodule-info.javawould raise that source-level assumption.Solution
Add
Automatic-Module-Name: com.google.flatbuffersthrough the existing bundle plugin manifest instructions. This gives JPMS users a stable module name while preserving the Java 8 runtime/build target.Addresses #9111.
Tests run
mvn -f java/pom.xml -Dmaven.test.skip=true clean packageMETA-INF/MANIFEST.MFfromjava/target/flatbuffers-java-25.12.19.jarjar --describe-module --file java/target/flatbuffers-java-25.12.19.jargit diff --check