Move full binding graph validation for modules from ModuleValidator to ModuleProcessingStep. - #5255
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_966148402
branch
from
August 18, 2026 20:00
b25ad99 to
71ccc54
Compare
…o ModuleProcessingStep. This change shifts the full binding graph validation of modules out of ModuleValidator (which is now only responsible for validating the individual module) and into ModuleProcessingStep. This is consistent with how we handle binding graph validation for components, which is done in ComponentProcessingStep rather than ComponentValidator. This also improves error reporting by pointing directly to the errors rather than generating secondary "module has errors" messages on referencing components. RELNOTES=N/A PiperOrigin-RevId: 966775864
copybara-service
Bot
force-pushed
the
test_966148402
branch
from
August 18, 2026 20:34
71ccc54 to
ad37e58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move full binding graph validation for modules from ModuleValidator to ModuleProcessingStep.
This change shifts the full binding graph validation of modules out of ModuleValidator (which is now only responsible for validating the individual module) and into ModuleProcessingStep.
This is consistent with how we handle binding graph validation for components, which is done in ComponentProcessingStep rather than ComponentValidator.
This also improves error reporting by pointing directly to the errors rather than generating secondary "module has errors" messages on referencing components.
RELNOTES=N/A