Conversation
Collaborator
Author
Certainly! The changes are now restricted to ones that related to technical concepts instead of more general language fixes. |
mgeisler
force-pushed
the
weasel-idiomatic
branch
from
c9925eb to
3b8d847
Compare
gribozavr
requested changes
Feb 16, 2026
Comment on lines
-33
to
+35
| - "to" methods most commonly take `&self`. However they can take `self` by value | ||
| if the type implements `Copy`: this also ensures that the conversion method | ||
| call does not consume `self`. | ||
| - "to" methods take `&self`. However they can take `self` by value if the type | ||
| implements `Copy`: this also ensures that the conversion method call does not | ||
| consume `self`. |
Comment on lines
-30
to
+32
| - `into_inner` is a method usually found on newtypes: types whose main purpose | ||
| is to wrap around an existing type and be semantically distinct from other | ||
| uses of that inner type. | ||
| - `into_inner` is a method found on newtypes: types whose main purpose is to | ||
| wrap around an existing type and be semantically distinct from other uses of | ||
| that inner type. |
Collaborator
There was a problem hiding this comment.
I'd say undo this one. It means that it is common, but not mandatory for newtypes to provide this method.
Comment on lines
-34
to
+35
| - These functions can take multiple arguments, but usually imply the user is | ||
| doing more of the work than a usual constructor would. | ||
| - These functions can take multiple arguments, but imply the user is expected to | ||
| provide the data that the type is composed of. |
Collaborator
There was a problem hiding this comment.
Is there a better rewrite that you can think of? I think there must be more smooth ways to say this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes imprecise language ('weasel words') to align with the new precision guidelines in #3029.
Note: This PR was generated using Gemini. Please review the changes accordingly. If the new style is not desired for this section, feel free to close this PR.