Skip to content

Fix flaky test. - #24

Open
qwandor wants to merge 2 commits into
mainfrom
flaky
Open

Fix flaky test.#24
qwandor wants to merge 2 commits into
mainfrom
flaky

Conversation

@qwandor

@qwandor qwandor commented Nov 30, 2023

Copy link
Copy Markdown
Collaborator

FD 3 might not be used already.

@qwandor
qwandor force-pushed the flaky branch 3 times, most recently from f32147b to 2d816c4 Compare December 1, 2023 15:22
@codecov-commenter

codecov-commenter commented Dec 12, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.03%. Comparing base (8299941) to head (a5ae0bd).
⚠️ Report is 52 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   42.96%   42.03%   -0.93%     
==========================================
  Files           3        3              
  Lines         775      804      +29     
==========================================
+ Hits          333      338       +5     
- Misses        442      466      +24     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kpcyrd

kpcyrd commented May 23, 2026

Copy link
Copy Markdown

hi! any chance this could get merged? :) the test failure also got flagged by the Debian Rust tooling.

@qwandor

qwandor commented May 26, 2026

Copy link
Copy Markdown
Collaborator Author

I'm not sure that this actually consistently helps. The issue here seems to be that GitHub Actions runner sometimes has extra file descriptors open. In what environment are you running tests for Debian? And does this patch consistently fix the issue for you?

@kpcyrd

kpcyrd commented May 26, 2026

Copy link
Copy Markdown

Applying the patches did not help unfortunately, tests are executed by autopkgtests in sbuild (I'm not that familiar with internals of that setup), I worked around this by disabling autopkgtests for this package: https://packages.debian.org/sid/librust-command-fds-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants