[Butler] Make local App Engine instance accessible from local network - #5422
Open
JuanMBriones wants to merge 1 commit into
Open
[Butler] Make local App Engine instance accessible from local network#5422JuanMBriones wants to merge 1 commit into
JuanMBriones wants to merge 1 commit into
Conversation
When developing locally or interacting with the ClusterFuzz web server from other devices on the local network (such as another workstation or test devices), the development App Engine server was bound only to `127.0.0.1`, preventing external access on the LAN. - Added `DEV_APPSERVER_ADDR = '0.0.0.0'` in `constants.py` and updated `DEV_APPSERVER_HOST` to use this address. - Updated `run_server.py` to bind gunicorn to `DEV_APPSERVER_HOST` instead of hardcoded `127.0.0.1`. - Ran `python butler.py lint` (passed). - Ran `python butler.py integration_tests` (passed). - Ran `python butler.py py_unittest -t core -m` (passed). - Ran `python butler.py py_unittest -t appengine -m` (passed). Signed-off-by: Manuel Briones <manuelbriones@google.com>
fernandofloresg
requested review from
ViniciustCosta,
dylanjew and
javanlacerda
August 11, 2026 16:32
dylanjew
approved these changes
Aug 11, 2026
Author
Hiii Dylan, thanks for the review!!!:D When working with devcontainers VSCode does the binding automatically (it makes available the running instance on the local network as well). That's why this is only focused when running the service through butler. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When developing locally or interacting with the ClusterFuzz web server from other devices on the local network (such as another workstation or test devices), the development App Engine server was bound only to
127.0.0.1, preventing external access on the LAN.Added
DEV_APPSERVER_ADDR = '0.0.0.0'inconstants.pyand updatedDEV_APPSERVER_HOSTto use this address.Updated
run_server.pyto bind gunicorn toDEV_APPSERVER_HOSTinstead of hardcoded127.0.0.1.Ran
python butler.py lint(passed).Ran
python butler.py integration_tests(passed).Ran
python butler.py py_unittest -t core -m(passed).Ran
python butler.py py_unittest -t appengine -m(passed).