Skip to content

[Corpus] Refactor and add wildcard support for feature flag - #5421

Open
PauloVLB wants to merge 1 commit into
masterfrom
corpus-fix-rollout
Open

[Corpus] Refactor and add wildcard support for feature flag#5421
PauloVLB wants to merge 1 commit into
masterfrom
corpus-fix-rollout

Conversation

@PauloVLB

@PauloVLB PauloVLB commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Problem

The previous feature flag implementation for enabling threaded storage operations was somewhat rigid and required explicitly listing every single fuzz target. This made it difficult to scale the solution or enable it globally for specific deployments (like OSS-Fuzz) without maintaining huge lists. Additionally, the matching was case-sensitive and didn't handle potential variations well, which could cause issues when testing across different deployments like Chrome or Google3.

Solution

Refactored the logic into a dedicated helper function _should_use_threaded_ops to improve readability and robustness.

  • The feature flag now supports * anywhere in the list to enable threaded operations for all targets in that specific deployment.
  • Both the incoming fuzzer name and the configuration list are converted to lowercase, preventing failures due to casing mismatches.
  • Flattened the nested conditions in _utask_preprocess by moving the decision logic out.

This prepares the feature for easier rollout and testing across different environments without requiring further code changes.

Note: I also improved a comment as requested in here.

Validation

The wildcard worker in dev:

image

GCP Link

@PauloVLB
PauloVLB force-pushed the corpus-fix-rollout branch from 22c057b to 87932d4 Compare August 11, 2026 15:09
@PauloVLB
PauloVLB marked this pull request as ready for review August 11, 2026 16:41
@PauloVLB
PauloVLB requested a review from a team as a code owner August 11, 2026 16:41
@PauloVLB
PauloVLB requested a review from decoNR August 11, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant