Make google-cloud-cli apt package installation conditional on rodete - #5419
Open
letitz wants to merge 1 commit into
Open
Make google-cloud-cli apt package installation conditional on rodete#5419letitz wants to merge 1 commit into
letitz wants to merge 1 commit into
Conversation
letitz
force-pushed
the
fix-rodete-gcloud-apt
branch
2 times, most recently
from
August 11, 2026 02:22
3115b45 to
3d872a6
Compare
letitz
commented
Aug 11, 2026
letitz
left a comment
letitz
left a comment
Collaborator
Author
There was a problem hiding this comment.
Let's mention the base PR in this PR's descrpition.
letitz
force-pushed
the
fix-rodete-gcloud-apt
branch
from
August 11, 2026 02:32
3d872a6 to
732844a
Compare
…lation conditional on rodete When running local environment setup (./local/install_deps.bash) on internal Google Linux workstations (rodete), apt-get fails when attempting to install several optional App Engine and Pub/Sub component packages that are not provided in internal apt repositories. Furthermore, attempting to add the docker-ce repository triggers interactive glogin authentication even when docker is already installed on the system. Specifically: - google-cloud-cli-app-engine-python, google-cloud-cli-app-engine-python-extras, google-cloud-cli-app-engine-go, and google-cloud-cli-pubsub-emulator apt packages are optional/unavailable on rodete (see internal references b/414408644 and b/484368884). - glogin and glinux-add-repo docker-ce-rodete should be skipped if docker is already installed on the machine. - Fix pipenv CLI invocation in local/install_python_deps_linux.bash. This commit updates local/install_deps_linux.bash to check $distro_codename and whether docker is installed. On rodete, only google-cloud-cli and google-cloud-cli-datastore-emulator are installed via apt-get, while non-rodete distributions retain the full component package list. Additionally adds local/tests/install_deps_test_linux.bash to test and verify fresh checkout setup on Linux.
letitz
force-pushed
the
fix-rodete-gcloud-apt
branch
from
August 11, 2026 02:51
732844a to
eaab759
Compare
dylanjew
approved these changes
Aug 11, 2026
Collaborator
Author
|
Thanks! Onto @ViniciustCosta for review. |
Collaborator
Author
|
I'm intentionally ignoring the docker image build failure, since that looks like it doesn't work at head - it also failed on #5420. |
Collaborator
That one's been flaky, I've tried retrying the job. |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running local environment setup (
./local/install_deps.bash) on internal Google Linux workstations (rodete),apt-getfails when attempting to install several optional App Engine and Pub/Sub component packages that are not provided in internal apt repositories. Furthermore, attempting to add thedocker-cerepository triggers interactivegloginauthentication even when Docker is already installed on the system.Specifically:
google-cloud-cli-app-engine-python,google-cloud-cli-app-engine-python-extras,google-cloud-cli-app-engine-go, andgoogle-cloud-cli-pubsub-emulatorapt packages are optional/unavailable onrodete(see internal references b/414408644 and b/484368884).gloginandglinux-add-repo docker-ce-rodeteshould be skipped ifdockeris already installed on the machine (if ! which docker).pipenvCLI invocation and virtual environment activation sequence inlocal/install_python_deps_linux.bash.This pull request updates
local/install_deps_linux.bashto inspect$distro_codenameand whetherdockeris installed. Onrodete, onlygoogle-cloud-cliandgoogle-cloud-cli-datastore-emulatorare installed viaapt-get, while non-rodete distributions retain the full component package list (includinggoogle-cloud-cli-app-engine-go).Additionally adds
local/tests/install_deps_test_linux.bashto test and verify fresh checkout environment installation on Linux.