Consolidate Untrusted Tasks to Preprocess Queue & Support Platform Filtering in ENABLE_FUZZ_FOR_BOTS - #5412
Open
javanlacerda wants to merge 4 commits into
Open
Consolidate Untrusted Tasks to Preprocess Queue & Support Platform Filtering in ENABLE_FUZZ_FOR_BOTS#5412javanlacerda wants to merge 4 commits into
javanlacerda wants to merge 4 commits into
Conversation
Signed-off-by: Javan Lacerda <javanlacerda@google.com>
…filtering in ENABLE_FUZZ_FOR_BOTS
javanlacerda
force-pushed
the
javan.consolidate-untrusted-tasks
branch
from
August 6, 2026 13:50
92f87ad to
9c0717a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those changes enforces that all UTasks are scheduled in the preprocess queue, assuring it would have the main stage being executed in a remote untrusted environment.
In other hand, it ensure that the Trusted tasks are scheduled to the
jobsqueues, to be processed by the bots in the no io mode (pre, main and pos in the same host)Summary
COMMAND_TYPESintask_types.pyas the single source of truth to classify tasks into untrusted (BaseUTask->UTask) and trusted (TrustedTask).analyze,corpus_pruning,fuzz,minimize,progression,regression,symbolize,variant) toPREPROCESS_QUEUE(orSWARMING_QUEUES[PREPROCESS_QUEUE]) insideadd_task().queue_for_platform,queue_for_job,queue_for_testcase) and existing callsites completely untouched for zero disruption.'fuzz': UTaskinCOMMAND_TYPES.ENABLE_FUZZ_FOR_BOTS:environment.platform().lower()is in the comma-separatedFeatureFlags.ENABLE_FUZZ_FOR_BOTS.string_valuebefore allowing idle long-lived bots to pull local fuzz tasks.Changes
'fuzz': UTaskLocalExecutorto'fuzz': UTaskinCOMMAND_TYPES.is_trusted_taskandis_untrusted_taskhelpers derived directly fromCOMMAND_TYPES.pub_sub_task_queueimport intoUTask.preprocessto avoid circular dependency.add_task(), automatically route untrusted tasks (is_untrusted_task(command)) toPREPROCESS_QUEUE(orSWARMING_QUEUES[PREPROCESS_QUEUE]).get_task()viaFeatureFlags.ENABLE_FUZZ_FOR_BOTS.GetTaskFuzzingFeatureFlagTestandTaskQueueResolutionTest.Verification
pipenv run python butler.py py_unittest -t core -p tasks_test.pypipenv run python butler.py py_unittest -t core -p task_types_test.pypipenv run python butler.py lintpipenv run python butler.py format