[VRP] Harden testcase safety check in long-lived bots - #5368
Draft
PauloVLB wants to merge 10 commits into
Draft
Conversation
PauloVLB
force-pushed
the
vrp-untrusted-testcase-safety
branch
5 times, most recently
from
July 16, 2026 20:37
627f503 to
6a39d40
Compare
PauloVLB
changed the base branch from
master
to
vrp-untrusted-testcases-from-fuzzers
July 16, 2026 20:39
PauloVLB
force-pushed
the
vrp-untrusted-testcase-safety
branch
from
July 16, 2026 20:59
6a39d40 to
20c1288
Compare
PauloVLB
force-pushed
the
vrp-untrusted-testcase-safety
branch
from
August 10, 2026 14:13
20c1288 to
3f3929c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Long-lived bots shouldn't be touching untrusted testcases locally (like during minimization). The old check used the
UNTRUSTED_UTASKenv var, which isn't reliable and leads to missed detections.Proposed Solution
Harden
check_handling_testcase_safeinuworker_io.pyto useenvironment.is_uworker()instead. If a long-lived bot (is_uworker()is False) tries to handle an untrusted testcase, it will immediately exit with a fatal error.Testing
Updated
minimize_task_test.py,test_utils.py, andutask_helpers.pyto default testcases totrusted=Trueso they don't trigger the new safety check during unrelated tests.Validation
Due to the difficulty of testing this in the dev environment and the lack of real untrusted fuzzers in production, this will be tested in the production environment.