Skip to content

[VRP] Harden testcase safety check in long-lived bots - #5368

Draft
PauloVLB wants to merge 10 commits into
vrp-untrusted-testcases-from-fuzzersfrom
vrp-untrusted-testcase-safety
Draft

[VRP] Harden testcase safety check in long-lived bots#5368
PauloVLB wants to merge 10 commits into
vrp-untrusted-testcases-from-fuzzersfrom
vrp-untrusted-testcase-safety

Conversation

@PauloVLB

@PauloVLB PauloVLB commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Problem

Long-lived bots shouldn't be touching untrusted testcases locally (like during minimization). The old check used the UNTRUSTED_UTASK env var, which isn't reliable and leads to missed detections.

Proposed Solution

Harden check_handling_testcase_safe in uworker_io.py to use environment.is_uworker() instead. If a long-lived bot (is_uworker() is False) tries to handle an untrusted testcase, it will immediately exit with a fatal error.

Testing

Updated minimize_task_test.py, test_utils.py, and utask_helpers.py to default testcases to trusted=True so they don't trigger the new safety check during unrelated tests.

Validation

Due to the difficulty of testing this in the dev environment and the lack of real untrusted fuzzers in production, this will be tested in the production environment.

@PauloVLB
PauloVLB force-pushed the vrp-untrusted-testcase-safety branch 5 times, most recently from 627f503 to 6a39d40 Compare July 16, 2026 20:37
@PauloVLB
PauloVLB changed the base branch from master to vrp-untrusted-testcases-from-fuzzers July 16, 2026 20:39
@PauloVLB
PauloVLB force-pushed the vrp-untrusted-testcase-safety branch from 6a39d40 to 20c1288 Compare July 16, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant