Add handling for reformatted archives conditional on archive format version #5145
+307
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
letitz
commented
Jan 27, 2026
Collaborator
Author
letitz
left a comment
letitz
left a comment
There was a problem hiding this comment.
First round. I'm excited to see this land!
letitz
commented
Jan 29, 2026
Collaborator
Author
letitz
left a comment
letitz
left a comment
There was a problem hiding this comment.
Smaller comments this time around, except that we still need tests :)
src/clusterfuzz/_internal/tests/core/build_management/build_archive_test.py
Show resolved
Hide resolved
src/clusterfuzz/_internal/tests/core/build_management/build_archive_test.py
Show resolved
Hide resolved
src/clusterfuzz/_internal/tests/core/build_management/build_archive_test.py
Show resolved
Hide resolved
letitz
commented
Jan 30, 2026
src/clusterfuzz/_internal/tests/core/build_management/build_archive_test.py
Outdated
Show resolved
Hide resolved
src/clusterfuzz/_internal/tests/core/build_management/build_archive_test.py
Outdated
Show resolved
Hide resolved
letitz
commented
Feb 3, 2026
src/clusterfuzz/_internal/tests/core/build_management/build_archive_test.py
Outdated
Show resolved
Hide resolved
src/clusterfuzz/_internal/tests/core/build_management/build_archive_test.py
Show resolved
Hide resolved
src/clusterfuzz/_internal/tests/core/build_management/build_archive_test.py
Outdated
Show resolved
Hide resolved
src/clusterfuzz/_internal/tests/core/build_management/build_archive_test.py
Outdated
Show resolved
Hide resolved
cemon721-a11y
approved these changes
Feb 4, 2026
cemon721-a11y
left a comment
cemon721-a11y
left a comment
There was a problem hiding this comment.
Thanks for the quick fix! Using getattr() to handle the missing attribute looks like the right approach. This will unblock our workflow." And if I did again some mistakes the kindly please Send Simply inbox To my Gmail address.
Contributor
|
It seems that lint is failing. Please fix it, thanks! |
Collaborator
Fixed! @decoNR can you take one more look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening on behalf of @mverde to start reviewing early.