Add ASP as primary setup in academic-research agent#1226
Add ASP as primary setup in academic-research agent#1226zeroasterisk merged 3 commits intogoogle:mainfrom
Conversation
Reverting: I was only supposed to approve the workflow runs, not the PR itself.
zeroasterisk
left a comment
There was a problem hiding this comment.
ASP Integration Checklist (ref: PR #1286 as approved template)
- ✅ ASP as recommended — correct positioning
- ✅
uvxone-liner as primary — good - ✅ Clean README structure
⚠️ Missing__init__.pyauth block — Nogoogle.auth.default()+os.environ.setdefaultblock. This is needed for the agent to work in ASP-generated projects with ADC. See #1286 or your own #1091 for the pattern.⚠️ Verify end-to-end — Doesuvx agent-starter-pack create+uv run adk runactually work for this agent? The auth block is usually what makes or breaks it.
Add the auth block in __init__.py and verify the agent runs in an ASP-scaffolded project.
0192fc7 to
a10ae37
Compare
Addressed: Google auth added
|
zeroasterisk
left a comment
There was a problem hiding this comment.
Looks good — auth block with correct import order (from . import agent after env setup with noqa), load_dotenv before auth. Clean. ✅
|
Hey @Almadhi07 — this PR has merge conflicts with git fetch upstream
git rebase upstream/main
# resolve any conflicts
git push --force-with-leaseThe PR is approved and ready to merge once conflicts are resolved. Thanks! 🙏 |
- load_dotenv, google.auth.default(), setdefault for project/location/vertex, then import agent - README: uvx primary, details for pip/clone, uv run adk, uv sync --group dev
4a8df35 to
002c06f
Compare

Summary:
pyproject.toml — Bumped agent-starter-pack from >=0.14.1 to >=0.32.0
README.md — Moved ASP setup from a bottom "Alternative" section to the primary setup option; removed the duplicate section
uv.lock — Regenerated to reflect the updated ASP dependency