fix(flows): stop after final preprocessing responses - #6869
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
fix(flows): stop after final preprocessing responses#6869sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
Auth and tool-confirmation resume processors can re-execute a paused tool during request preprocessing. When that tool response sets
skip_summarization, the response is already final, but_run_one_step_asynccontinued into another model call. The unwanted model response then replaced the tool response as the last event.This change records whether preprocessing emitted a final response and returns after preprocessing completes. Non-final preprocessing events continue through the normal model path.
Testing Plan
skip_summarization=Trueand fails if the model is called.pytest -q tests/unittests/flows/llm_flows/test_base_llm_flow.py tests/unittests/flows/llm_flows/test_request_confirmation.py tests/unittests/auth/test_auth_preprocessor.py.Checklist
CONTRIBUTING.mddocument.