fix: persist events after plugin on_event_callback modifications#4239
Open
Ponts wants to merge 1 commit intogoogle:mainfrom
Open
fix: persist events after plugin on_event_callback modifications#4239Ponts wants to merge 1 commit intogoogle:mainfrom
Ponts wants to merge 1 commit intogoogle:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Problem:
on_event_callback executes after append_event, preventing plugin modifications from being persisted #3990
Solution:
Run callbacks before persisting events.
Testing Plan
Ran python tests/unittests and verified all tests passed.
There exists tests that verify that events are yielded from the runner.
Unit Tests:
Manual End-to-End (E2E) Tests:
Checklist