-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(memory): add SQLite memory service #4116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @summerx96, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a robust, persistent local memory solution for the ADK by integrating a new SQLite-based memory service. This enhancement allows for reliable storage and retrieval of session data, improving the framework's ability to maintain context across interactions. The service is designed for efficiency with idempotent updates and intelligent search capabilities, making it a valuable addition for applications requiring durable memory without external database dependencies. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Response from ADK Triaging Agent Hello @summerx96, thank you for creating this PR! Before we can review your contribution, could you please sign the Contributor License Agreement (CLA)? It seems the check is currently failing. Also, for a new feature like this, could you please create and associate a GitHub issue with this PR? This helps us track new features and discussions around them. Additionally, it would be very helpful for the reviewers if you could provide a screenshot or some logs demonstrating the new SQLite memory service in action. This information will help reviewers to review your PR more efficiently. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new SqliteMemoryService, providing a persistent, local memory option for ADK. The implementation is well-structured, featuring optional FTS5 full-text search with a LIKE fallback, idempotent session upserts, and a configurable extraction mechanism. The changes are accompanied by clear documentation and a good set of unit tests covering key functionalities like idempotency, updates, persistence, and FTS usage. My feedback focuses on improving the robustness of data parsing and enhancing code conciseness in a helper function.
| parts = [] | ||
| for part in event.content.parts: | ||
| if not part.text: | ||
| continue | ||
| if getattr(part, "thought", False): | ||
| continue | ||
| text = part.text.replace("\n", " ").strip() | ||
| if text: | ||
| parts.append(text) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic for extracting text parts from an event can be made more concise by using a list comprehension with an assignment expression (walrus operator :=). This improves readability by reducing nesting and making the intent clearer.
parts = [
text
for part in event.content.parts
if part.text and not getattr(part, "thought", False)
if (text := part.text.replace("\n", " ").strip())
]| if row["metadata_json"]: | ||
| metadata["metadata"] = json.loads(row["metadata_json"]) | ||
| if row["extracted_json"]: | ||
| metadata["extracted"] = json.loads(row["extracted_json"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The json.loads calls could fail if the data in metadata_json or extracted_json is corrupted, which would cause the entire search request to fail. To make this more robust, consider wrapping them in try...except json.JSONDecodeError blocks to gracefully handle potential data corruption.
if row["metadata_json"]:
try:
metadata["metadata"] = json.loads(row["metadata_json"])
except json.JSONDecodeError:
# Consider logging a warning about data corruption.
pass
if row["extracted_json"]:
try:
metadata["extracted"] = json.loads(row["extracted_json"])
except json.JSONDecodeError:
# Consider logging a warning about data corruption.
pass|
Addressed this: wrapped metadata_json/extracted_json loads in try/except JSONDecodeError with warning logs so corrupted rows don't break search. |
d09e104 to
7b8fe1a
Compare
Summary
Testing