Skip to content

Conversation

@summerx96
Copy link

Summary

  • add stdlib-only SQLite memory service with optional FTS5 and LIKE fallback
  • implement upsert/idempotency and snippet-based memory entries
  • register sqlite:// memory scheme with tests
  • document SQLite usage in memory sample

Testing

  • .venv/bin/python -m pytest tests/unittests/memory/test_sqlite_memory_service.py tests/unittests/cli/test_service_registry.py

@google-cla
Copy link

google-cla bot commented Jan 11, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @summerx96, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a robust, persistent local memory solution for the ADK by integrating a new SQLite-based memory service. This enhancement allows for reliable storage and retrieval of session data, improving the framework's ability to maintain context across interactions. The service is designed for efficiency with idempotent updates and intelligent search capabilities, making it a valuable addition for applications requiring durable memory without external database dependencies.

Highlights

  • New SQLite Memory Service: A new memory service has been added that uses SQLite for persistent local storage, built using only standard Python libraries. It includes optional support for FTS5 for advanced full-text search, with a fallback to SQL LIKE queries if FTS5 is unavailable.
  • Idempotent Session Management: The service implements upsert logic and content hashing to ensure that adding a session is idempotent, meaning sessions are only updated if their content has genuinely changed, preventing redundant writes.
  • Snippet-Based Memory Entries: Memory entries returned from searches are now snippet-based, providing concise and relevant portions of the stored session content, improving search result readability.
  • Service Registry Integration: The new SQLite memory service is registered with the ADK's service registry, allowing it to be easily configured and used via a sqlite:// URI scheme in both programmatic and CLI contexts.
  • Documentation and Testing: Usage of the SQLite memory service is documented in the memory sample README, and comprehensive unit tests have been added to cover its core functionalities, including idempotency, persistence, and search.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@adk-bot adk-bot added the services [Component] This issue is related to runtime services, e.g. sessions, memory, artifacts, etc label Jan 11, 2026
@adk-bot
Copy link
Collaborator

adk-bot commented Jan 11, 2026

Response from ADK Triaging Agent

Hello @summerx96, thank you for creating this PR!

Before we can review your contribution, could you please sign the Contributor License Agreement (CLA)? It seems the check is currently failing.

Also, for a new feature like this, could you please create and associate a GitHub issue with this PR? This helps us track new features and discussions around them.

Additionally, it would be very helpful for the reviewers if you could provide a screenshot or some logs demonstrating the new SQLite memory service in action.

This information will help reviewers to review your PR more efficiently. Thanks!

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new SqliteMemoryService, providing a persistent, local memory option for ADK. The implementation is well-structured, featuring optional FTS5 full-text search with a LIKE fallback, idempotent session upserts, and a configurable extraction mechanism. The changes are accompanied by clear documentation and a good set of unit tests covering key functionalities like idempotency, updates, persistence, and FTS usage. My feedback focuses on improving the robustness of data parsing and enhancing code conciseness in a helper function.

Comment on lines +479 to +490
parts = []
for part in event.content.parts:
if not part.text:
continue
if getattr(part, "thought", False):
continue
text = part.text.replace("\n", " ").strip()
if text:
parts.append(text)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The logic for extracting text parts from an event can be made more concise by using a list comprehension with an assignment expression (walrus operator :=). This improves readability by reducing nesting and making the intent clearer.

  parts = [
      text
      for part in event.content.parts
      if part.text and not getattr(part, "thought", False)
      if (text := part.text.replace("\n", " ").strip())
  ]

Comment on lines 538 to 541
if row["metadata_json"]:
metadata["metadata"] = json.loads(row["metadata_json"])
if row["extracted_json"]:
metadata["extracted"] = json.loads(row["extracted_json"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The json.loads calls could fail if the data in metadata_json or extracted_json is corrupted, which would cause the entire search request to fail. To make this more robust, consider wrapping them in try...except json.JSONDecodeError blocks to gracefully handle potential data corruption.

  if row["metadata_json"]:
    try:
      metadata["metadata"] = json.loads(row["metadata_json"])
    except json.JSONDecodeError:
      # Consider logging a warning about data corruption.
      pass
  if row["extracted_json"]:
    try:
      metadata["extracted"] = json.loads(row["extracted_json"])
    except json.JSONDecodeError:
      # Consider logging a warning about data corruption.
      pass

@summerx96
Copy link
Author

Addressed this: wrapped metadata_json/extracted_json loads in try/except JSONDecodeError with warning logs so corrupted rows don't break search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

services [Component] This issue is related to runtime services, e.g. sessions, memory, artifacts, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants