Skip to content

Add initial devcontainer configuration #4068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Maxdienz wants to merge 1 commit into from
Closed

Add initial devcontainer configuration #4068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"image": "mcr.microsoft.com/devcontainers/universal:2",
"features": {}
}
Comment on lines +1 to +4
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This is a good start for the devcontainer configuration. To make it more useful for developers working on this Python project, I suggest a few enhancements:

  • Name: Add a descriptive name for the container for better identification.
  • Python Version: Explicitly set the Python version to 3.11 using a devcontainer feature, as this is the recommended version in CONTRIBUTING.md.
  • Automated Setup: Use postCreateCommand to automatically install uv and sync the project dependencies. This will fully prepare the development environment upon creation.
  • VS Code Customizations:
    • Add recommended extensions for Python development (ms-python.python, ms-python.vscode-pylance, charliermarsh.ruff).
    • Configure VS Code settings to automatically use the correct Python interpreter, set up pytest for easy test execution, and enable auto-formatting on save using ruff.

These changes will provide a more complete and ready-to-use development environment for anyone using the devcontainer.

{
  "name": "ADK Python Dev Container",
  "image": "mcr.microsoft.com/devcontainers/universal:2",
  "features": {
    "ghcr.io/devcontainers/features/python:1": {
      "version": "3.11"
    }
  },
  "postCreateCommand": "pip install uv && uv sync --all-extras",
  "customizations": {
    "vscode": {
      "settings": {
        "python.defaultInterpreterPath": "/usr/local/python/bin/python",
        "python.testing.pytestArgs": [
          "tests/unittests"
        ],
        "python.testing.unittestEnabled": false,
        "python.testing.pytestEnabled": true,
        "[python]": {
          "editor.defaultFormatter": "charliermarsh.ruff",
          "editor.formatOnSave": true
        }
      },
      "extensions": [
        "ms-python.python",
        "ms-python.vscode-pylance",
        "charliermarsh.ruff"
      ]
    }
  }
}