-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix: issue 3785. id_token missing #3786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c9eb67e
fix: issue 3785. Add id_token field and fill it when available in the…
guillaumeblaquiere f1c74e7
test: add id_token in test
guillaumeblaquiere 3744fb0
Merge branch 'main' into fix-3785
guillaumeblaquiere f153943
Merge branch 'main' into fix-3785
guillaumeblaquiere c208c77
chore: autoformat.sh
guillaumeblaquiere d5c5319
Merge branch 'main' into fix-3785
guillaumeblaquiere aa430c7
Merge branch 'main' into fix-3785
guillaumeblaquiere 54d4d00
Merge branch 'main' into fix-3785
guillaumeblaquiere feaf945
Merge branch 'main' into fix-3785
guillaumeblaquiere abc3e08
Merge branch 'main' into fix-3785
guillaumeblaquiere fc8d1b3
Merge branch 'main' into fix-3785
guillaumeblaquiere 2381c91
Merge branch 'main' into fix-3785
guillaumeblaquiere 60ee6b3
Merge branch 'main' into fix-3785
guillaumeblaquiere 2ef4782
Merge branch 'main' into fix-3785
guillaumeblaquiere a223d26
Merge branch 'main' into fix-3785
guillaumeblaquiere d5f6142
Merge branch 'main' into fix-3785
guillaumeblaquiere 77eaa98
Merge branch 'main' into fix-3785
guillaumeblaquiere 2973e2c
chore: fix unit test
guillaumeblaquiere 65b78b5
Merge branch 'main' into fix-3785
guillaumeblaquiere 2ad63b1
Merge branch 'main' into fix-3785
guillaumeblaquiere 828d0d0
Merge branch 'main' into fix-3785
guillaumeblaquiere File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -108,6 +108,7 @@ def update_credential_with_tokens( | |
| """ | ||
| auth_credential.oauth2.access_token = tokens.get("access_token") | ||
| auth_credential.oauth2.refresh_token = tokens.get("refresh_token") | ||
| auth_credential.oauth2.id_token = tokens.get("id_token", None) | ||
|
rohityan marked this conversation as resolved.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Populating the |
||
| auth_credential.oauth2.expires_at = ( | ||
| int(tokens.get("expires_at")) if tokens.get("expires_at") else None | ||
| ) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding
id_token: Optional[str] = Noneto theOAuth2Authclass is a direct and necessary change to support theid_tokenin the OIDC flow, as described in the PR. This correctly extends the data model to accommodate the new token type.